Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quoted Rscript path #33

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
2 participants
@fradav
Copy link
Contributor

fradav commented Jun 14, 2018

Without the quotes it couldn't launch the Rscript.exe if there is space in the path.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Jun 14, 2018

Technically true but the R documentation (likely the R Inst + Admin manual, and other places) also ask not to install in a path with spaces... yet R still defaults to that.

@eddelbuettel eddelbuettel merged commit 7104ed1 into eddelbuettel:master Jun 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Jun 14, 2018

Please send me an actual name I can use eg in ChangeLog to credit your PR.

@fradav

This comment has been minimized.

Copy link
Contributor Author

fradav commented Jun 14, 2018

François-David Collin
Yes you're right, it's mro from Microsoft, but you can force to take a standard path anyway.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Jun 14, 2018

Thanks, added in 79edd6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.