Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding a C interface #43
Merged
Conversation
|
LGTM. Minor comment: hello.c and passdata.c have strange spacing. Probably mixed tabs and spaces. |
|
Good catch. Spacing may be a consequence of moving from the emacs header in line 1 (old files) to using editorconfig. I'll run untabify. My default generally is four spaces for R and C(++). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is based on the initial work by @bachmeil plus a little spit and polish.
@bachmeil: Can you review just in base?