Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: implement messageToJson #61

Closed
botanize opened this issue Oct 9, 2019 · 6 comments
Closed

Feature request: implement messageToJson #61

botanize opened this issue Oct 9, 2019 · 6 comments
Labels

Comments

@botanize
Copy link

@botanize botanize commented Oct 9, 2019

The python protobuf package easily converts a message into a json implementation. See https://developers.google.com/protocol-buffers/docs/reference/python/

The RProtoBuf functions toString and as.character create text representations that look like JSON, but aren't (they're mostly missing commas and quotes). I think it would be wonderful to have a fast C implementation of this, especially as the as.list function doesn't work recursively.

@botanize
Copy link
Author

@botanize botanize commented Oct 10, 2019

Unfortunately I have very little experience with c and none with c++. The best I could do would be to attempt to reformat the as.character output with grep pattern replacements. But I don't think that's a good idea.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Oct 10, 2019

No we'd need someone with a few spare hours, interest and and enough knowledge to export the function in that third link I showed. I'll add a 'help wanted' label but I won't have time in the near future.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Mar 19, 2020

A big BIG BIG Thank You! to @siddharthab for making it happen. Soon to be on a CRAN mirror near you.

@siddharthab
Copy link
Contributor

@siddharthab siddharthab commented Mar 19, 2020

A big BIG BIG Thank You! to @siddharthab for making it happen. Soon to be on a CRAN mirror near you.

Just trying to keep promises I made long ago. 😄
#6 (comment)

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Mar 19, 2020

Hah! That was indeed a long(ish) time ago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.