New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building with custom CXXFLAGS and LDFLAGS #15
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4202,7 +4202,8 @@ fi | |
if test -z "${R_HOME}"; then | ||
as_fn_error $? "Could not determine R_HOME." "$LINENO" 5 | ||
fi | ||
CXXFLAGS=`"${R_HOME}/bin/R" CMD config CXXFLAGS` | ||
R_CXXFLAGS=`"${R_HOME}/bin/R" CMD config CXXFLAGS` | ||
CXXFLAGS="${CXXFLAGS} ${R_CXXFLAGS}" | ||
|
||
# We need this to get some limited int64 support with Rcpp. | ||
if test "x$ax_cv_cxx_compile_cxx0x_cxx" = "xyes" ; then | ||
|
@@ -4263,7 +4264,7 @@ fi | |
## now use all these | ||
PKG_CPPFLAGS="${PKG_CPPFLAGS} ${CXXFLAGS} $protobuf_cxxflags" | ||
|
||
PKG_LIBS="${PKG_LIBS} $rcpp_ldflags $protobuf_libs" | ||
PKG_LIBS="${PKG_LIBS} ${LDFLAGS} $rcpp_ldflags $protobuf_libs" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't that come in from R? May not do harm here, but might get added twice? (Comment belongs to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right. I removed the LDFLAGS inclusion from my working copy and it looks as if |
||
|
||
R_HOME="${R_HOME}" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good catch.
(Comment belongs to
configure.in
, of course.)