Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new travis -- with a proto v2/v3 matrix #16

Merged
merged 5 commits into from Aug 16, 2016
Merged

Conversation

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Aug 13, 2016

I switched to my maintained fork of the old r-travis setup (personal preference, mostly).

I also turned on a simple 'v2 versus v3' matrix. I did setup builds of ProtoBuf 3.0.0 via Launchpad yesterday -- a bit of hack as I removed gmock (build complications) and Java (we don't need it). I haven't really tested these packages but they should provide genuine ProtoBuf 3.0.0 for us.

So once the PR is in I'll a PR for the keywords

now against updated protobuf packages in PPA
@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Aug 13, 2016

And this now works correctly (after I corrected a snafu in the Launchpad-generated packages). See eg this build log which has

[...]
* checking for missing documentation entries ... WARNING
[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: /home/travis/build/eddelbuettel/rprotobuf/RProtoBuf.Rcheck/RProtoBuf/proto/addressbook.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: /home/travis/build/eddelbuettel/rprotobuf/RProtoBuf.Rcheck/RProtoBuf/proto/helloworld.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
[libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax specified for the proto file: /home/travis/build/eddelbuettel/rprotobuf/RProtoBuf.Rcheck/RProtoBuf/proto/rexp.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
All user-level objects in a package should have documentation entries.
See chapter ‘Writing R documentation files’ in the ‘Writing R
Extensions’ manual.
[...]
@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Aug 15, 2016

No objections? May merge this by end of day.

@eddelbuettel eddelbuettel merged commit 6d85059 into master Aug 16, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/new-travis branch Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.