Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd 'proto2' declarations (closes: #6) #17
Merged
Conversation
will look into why addressbook test failed commitinf changes as test for v2 + v3 Travis setup previously tested against custom Docker images with v2 and v3
Closed
|
Comments, anyone? If not I plan to merge later this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
now that we have working Travis support for testing proto2 and proto3, here is a first cleanup of adding the proto2 declaration desired by proto3 (and ignored by proto2).
in doing this one unit test needn't to be deactivated, you see it below -- it is file permission corner case in the temp directory and maybe just maybe something changed with R. not sure, but also not super important.