Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure 0-length character vectors are correctly deserialized (closes #13) #18

Merged
merged 2 commits into from Sep 1, 2016

Conversation

@oliverbock
Copy link

@oliverbock oliverbock commented Sep 1, 2016

unlist() will not give the vector the correct type when it is called on an empty list (see Issue #13). This coerces the vectors to the correct type. (This should also affect complex, so I applied the fix to it too.)

Ubuntu added 2 commits Sep 1, 2016
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Sep 1, 2016

Thanks, that looks good to me. Thoughts, @murraystokely ?

@eddelbuettel eddelbuettel changed the title Issue #13: Ensure 0-length character vectors are correctly deserialized Ensure 0-length character vectors are correctly deserialized (closes #13) Sep 1, 2016
@eddelbuettel eddelbuettel merged commit 5c34668 into eddelbuettel:master Sep 1, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eddelbuettel added a commit that referenced this pull request Sep 1, 2016
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Sep 1, 2016

@oliverbock Added a ChangeLog and NEWS entry; 6d8ae7a
if you want an email address logged send me one by email (or just add it here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.