Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature/registration #26
Merged
Conversation
add mising PACKAGE= argument correct one package= to PACKAGE remove one extra set of ... comment out one helper function
|
Will move ahead with this as nobody cried uncle... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@murraystokely @jeroenooms If you have a moment for a quick code review I'd appreciate it
Background: Mass email by Kurt requesting changes where
.Callhadpackage=...argument. We had that in one spot, we also had a few wherePACKAGE=was missing fixed.I added registration support which r-devel now suggests and soon requires. That uncovered a few issues:
Message__clonewhich was once called with extra...that is not needed.Call()helper functionsrc/init.cuncovered a entry points that are registered (ie have.Call()) but don't exist, so those registrations are commented