Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't crash the deserializer if object has an invalid class set #29
Conversation
|
The PR fails on the unit tests, and that is a no-no. |
|
fixed now, made a few too many assumptions about the class attribute |
|
@eddelbuettel, could I get your thoughts on the new PR? I just added a catch condition to handle this specific case. |
|
Truly sorry, caught that then ten days ago and was side-tracked, and it got overlooked. Will take another look. |
|
Looks fine to me. Anybody else want to comment? |
eddelbuettel
merged commit d0e8838
into
eddelbuettel:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Relates to #28