Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinite recursion if sub indexing list returns the list (closes #37) #38

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
@jefshe
Copy link
Contributor

jefshe commented Nov 20, 2017

Relates to #37

x <- package_version("1.2")
identical(x,unserialize_pb(serialize_pb(x, NULL)))
> [1] TRUE

Seems to work as expected now

@eddelbuettel eddelbuettel changed the title Avoid infinite recursion if sub indexing list returns the list Avoid infinite recursion if sub indexing list returns the list (closes #37) Nov 21, 2017

@eddelbuettel eddelbuettel merged commit d0eb8dc into eddelbuettel:master Nov 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

eddelbuettel added a commit that referenced this pull request Nov 21, 2017

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Nov 21, 2017

Thanks again for the nice and clean PR. I added two commits with a unit test, and then some householding for ChangeLog and NEWS and a new minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.