New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclass lists before serializing them #48

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@jefshe
Contributor

jefshe commented Aug 23, 2018

as some classes overwrite the default accessor.

Relates to #47

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Aug 23, 2018

I am a bit worried that this is too broad, altering behaviour for "all lists".

Could we narrow it ?

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Aug 25, 2018

As I said two days ago, I am not sure we can accept a PR that alters the behaviour for all lists unconditionally. As shown in #47 you can work around the POSIXlt issue by using POSIXct.

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Aug 30, 2018

As just mentioned in #47 I plan to close this unless I hear from you. An avoidable (via POSIXct) issue for POSIXlt is not good enough motivation to change behaviour for all lists. Or am I missing something? If so, please explain.

@eddelbuettel eddelbuettel merged commit edeb7b1 into eddelbuettel:master Sep 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment