Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnclass lists before serializing them #48
Merged
Conversation
|
I am a bit worried that this is too broad, altering behaviour for "all lists". Could we narrow it ? |
|
As I said two days ago, I am not sure we can accept a PR that alters the behaviour for all lists unconditionally. As shown in #47 you can work around the |
|
As just mentioned in #47 I plan to close this unless I hear from you. An avoidable (via |
eddelbuettel
merged commit edeb7b1
into
eddelbuettel:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
as some classes overwrite the default accessor.
Relates to #47