Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a S3 dispatch of all.equal() for Message objects and use it in S4 method #54

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@jarodmeng
Copy link
Contributor

commented Nov 26, 2018

This is to fix #53.

More details on the need to create both S3 and S4 methods for the same generic.

@eddelbuettel
Copy link
Owner

left a comment

That looks pretty good and minimal so I will give is a thumbs up.

What would be extra nice: an entry to ChangeLog (tab spacing, it is an old Emacs tradition), and/or an entry to inst/NEWS.Rd (standard Rd) and/or an extra unit test for this. If you have moment to add this; I won't get to this before this evening anyway.

@eddelbuettel eddelbuettel merged commit 2a8d691 into eddelbuettel:master Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Nov 27, 2018

Added ChangeLog and NEWS in 6298c7c -- thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.