Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a S3 dispatch of all.equal() for Message objects and use it in S4 method #54
Conversation
|
That looks pretty good and minimal so I will give is a thumbs up. What would be extra nice: an entry to ChangeLog (tab spacing, it is an old Emacs tradition), and/or an entry to inst/NEWS.Rd (standard Rd) and/or an extra unit test for this. If you have moment to add this; I won't get to this before this evening anyway. |
eddelbuettel
merged commit 2a8d691
into
eddelbuettel:master
1 check passed
1 check passed
|
Added ChangeLog and NEWS in 6298c7c -- thanks again for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is to fix #53.
More details on the need to create both S3 and S4 methods for the same generic.