Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upJSON parsing and printing for messages #68
Conversation
|
Nice work -- the PR looks very clean. I will take another, closer, look later. |
|
I made a minor local commit to get rid of two warnings under |
6099525
into
eddelbuettel:master
|
Thank you for the quick review. |
|
My pleasure -- thanks for the PR. I tend to get to get to things sooner, but I had a distration from a Rcpp release which may need a follow-up given an issue on macOS we did not catch / could not catch for lack of reverse-depends checking infrastructure on macOS :-/ Plus an issue with BioConductor which I may have to add to the test matrix... I presume you looked at my follow-up commit and have no issues? I added you to ChangeLog too. |
|
Thanks! The changes in the follow-up commit look good. The next thing I would like to add when I have the time is to return a helpful message when people mistype field names instead of segfaulting. |
|
Having slept over it, I think I will restore the small 'if open' change. Catching such a segfault would be awesome! I'll release this as an interim version with JSON support. |
|
I just looked at it in more detail. Removing the condition in the |
|
Sounds good. |
Resolves #61.