Feature/curl support #30

Merged
merged 5 commits into from Jan 26, 2017

Projects

None yet

2 participants

@restonslacker
Contributor

address issues in #29. principally removing the dependence on a system installation of the curl binary by using the cran package curl

@eddelbuettel
Owner

The Travis break is "mine" as I prefer the old-school explicit Travis. Please add

  - ./travis-tool.sh install_aptget r-cran-curl

I will update the Travis file once we're done.

.travis.yml
@@ -18,6 +18,7 @@ before_install:
install:
- ./travis-tool.sh install_r RJSONIO
+ - ./travis-tool.sh install_r curl
@eddelbuettel
eddelbuettel Jan 23, 2017 Owner

If both go to install_r you can just have multiple args on one line.

But it is faster to do install_aptget r-cran-curl which should (!!) be resolvable. Else I address.

@eddelbuettel

"request" makes me sound to powerful. More like "suggestion" ;-)

@restonslacker
Contributor

git commit --amend -m "change to install_aptget r-cran-curl per suggestion from @eddelbuettel"
=P

@restonslacker restonslacker Added check for return codes from POST. If return code is not 200, a …
…warning is thrown.

Also added tests to make sure certain pushes fail.
11afbb0
@eddelbuettel
Owner

last commit looks good

need to get an updated digest package out the door, this may be next. getting to the point where I'd need a unified GH issue dashboard :-/

@restonslacker
Contributor

thanks!

there is one, but maybe it's a little too basic for you: https://github.com/issues

@eddelbuettel
Owner

yes, I should probably use that more.

@eddelbuettel

I will merge this and give it a spin.

@eddelbuettel eddelbuettel merged commit 3d8222a into eddelbuettel:master Jan 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel
Owner

I made one post-PR commit to update a few things, now R CMD check is again happy.

You may need to pull this, and if we want to keep the other PR alive it may need some aligning.

@restonslacker
Contributor

WRT the changeLog, support for "address" pushes was removed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment