Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature/curl support #30
Conversation
…g. still an issue with file uploads.
|
The Travis break is "mine" as I prefer the old-school explicit Travis. Please add I will update the Travis file once we're done. |
| @@ -18,6 +18,7 @@ before_install: | |||
|
|
|||
| install: | |||
| - ./travis-tool.sh install_r RJSONIO | |||
| - ./travis-tool.sh install_r curl | |||
eddelbuettel
Jan 23, 2017
Owner
If both go to install_r you can just have multiple args on one line.
But it is faster to do install_aptget r-cran-curl which should (!!) be resolvable. Else I address.
If both go to install_r you can just have multiple args on one line.
But it is faster to do install_aptget r-cran-curl which should (!!) be resolvable. Else I address.
This comment has been minimized.
This comment has been minimized.
|
"request" makes me sound to powerful. More like "suggestion" ;-) |
|
|
…warning is thrown. Also added tests to make sure certain pushes fail.
|
last commit looks good need to get an updated digest package out the door, this may be next. getting to the point where I'd need a unified GH issue dashboard :-/ |
|
thanks! there is one, but maybe it's a little too basic for you: https://github.com/issues |
|
yes, I should probably use that more. |
|
I will merge this and give it a spin. |
eddelbuettel
merged commit 3d8222a
into
eddelbuettel:master
|
I made one post-PR commit to update a few things, now You may need to pull this, and if we want to keep the other PR alive it may need some aligning. |
|
WRT the changeLog, support for "address" pushes was removed as well. |
address issues in #29. principally removing the dependence on a system installation of the curl binary by using the cran package curl