Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to write single elements as vectors instead of lists when using j… #37

Merged
merged 1 commit into from Feb 1, 2017

Conversation

@restonslacker
Copy link
Contributor

commented Feb 1, 2017

…sonlite::toJSON in pbSetup. pbSetup is the only function in the package that calls to toJSON at the moment.

fix to write single elements as vectors instead of lists when using j…
…sonlite::toJSON in pbSetup. pbSetup is the only function in the package that calls to toJSON at the moment.
@eddelbuettel
Copy link
Owner

left a comment

That looks good. But it still leaves the problem with tests...

@eddelbuettel eddelbuettel merged commit e6d967b into eddelbuettel:master Feb 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@restonslacker

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2017

really? which ones? there are two tests (lines 142 and 162) that are supposed to throw errors. those errors are caught and handled, but it does print to the screen as if there were a problem.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Feb 1, 2017

Really. That is what I wrote about in #36 last night. Let us resume there. I will lock this thread.

Remember that MY dotfile had several entries, rather than one in your case. And that messes things up. We have gotten to a somewhat complicated and rich interface to pbPost() by now ... but I think it worked in all cases.

Repository owner locked and limited conversation to collaborators Feb 1, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.