Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix to write single elements as vectors instead of lists when using j… #37
Conversation
…sonlite::toJSON in pbSetup. pbSetup is the only function in the package that calls to toJSON at the moment.
|
That looks good. But it still leaves the problem with tests... |
eddelbuettel
merged commit e6d967b
into
eddelbuettel:master
1 check passed
1 check passed
|
really? which ones? there are two tests (lines 142 and 162) that are supposed to throw errors. those errors are caught and handled, but it does print to the screen as if there were a problem. |
|
Really. That is what I wrote about in #36 last night. Let us resume there. I will lock this thread. Remember that MY dotfile had several entries, rather than one in your case. And that messes things up. We have gotten to a somewhat complicated and rich interface to |
Repository owner
locked and limited conversation to collaborators
Feb 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
…sonlite::toJSON in pbSetup. pbSetup is the only function in the package that calls to toJSON at the moment.