fix to write single elements as vectors instead of lists when using j… #37

Merged
merged 1 commit into from Feb 1, 2017

Projects

None yet

2 participants

@restonslacker
Contributor

…sonlite::toJSON in pbSetup. pbSetup is the only function in the package that calls to toJSON at the moment.

@restonslacker restonslacker fix to write single elements as vectors instead of lists when using j…
…sonlite::toJSON in pbSetup. pbSetup is the only function in the package that calls to toJSON at the moment.
fa8affc
@eddelbuettel

That looks good. But it still leaves the problem with tests...

@eddelbuettel eddelbuettel merged commit e6d967b into eddelbuettel:master Feb 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@restonslacker
Contributor

really? which ones? there are two tests (lines 142 and 162) that are supposed to throw errors. those errors are caught and handled, but it does print to the screen as if there were a problem.

@eddelbuettel
Owner
eddelbuettel commented Feb 1, 2017 edited

Really. That is what I wrote about in #36 last night. Let us resume there. I will lock this thread.

Remember that MY dotfile had several entries, rather than one in your case. And that messes things up. We have gotten to a somewhat complicated and rich interface to pbPost() by now ... but I think it worked in all cases.

@eddelbuettel eddelbuettel locked and limited conversation to collaborators Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.