Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functions to check validity #41

Merged

Conversation

@restonslacker
Copy link
Contributor

@restonslacker restonslacker commented Feb 6, 2017

updated NAMESPACE with additonal curl function 'curl_escape'

first PR for #40

updated NAMESPACE with additonal curl function 'curl_escape'
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Feb 6, 2017

Just glanced at it real quick, looks great -- thanks for the continued excellent work.

Will review later / this eve.

Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Looks good!

I still put whitespace around if (conf) { but that is all small potatos.

@eddelbuettel eddelbuettel merged commit 9827cba into eddelbuettel:master Feb 8, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.