Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/travis with token #45

Merged
merged 2 commits into from Feb 11, 2017
Merged

Feature/travis with token #45

merged 2 commits into from Feb 11, 2017

Conversation

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Feb 11, 2017

=:-)

We now have Travis tests

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 11, 2017

Codecov Report

No coverage uploaded for pull request base (master@2a75c6f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #45   +/-   ##
========================================
  Coverage          ?   54.7%           
========================================
  Files             ?       7           
  Lines             ?     287           
  Branches          ?       0           
========================================
  Hits              ?     157           
  Misses            ?     130           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a75c6f...190e565. Read the comment docs.

@eddelbuettel eddelbuettel merged commit ea652c3 into master Feb 11, 2017
3 checks passed
3 checks passed
codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@restonslacker
Copy link
Contributor

@restonslacker restonslacker commented Feb 11, 2017

Very nice!

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Feb 11, 2017

Hope we didn't jinx it. Promptly failed. May have been temporary. Running now.

And I gamed the coverage stats like the best of them :)

Shall we turn off the @nord tags you added? If documentation was written why not show it?

@restonslacker
Copy link
Contributor

@restonslacker restonslacker commented Feb 11, 2017

Ha!

WRT the @nord tag, those were only on the .isValid* functions which aren't currently exported. I wanted to leave documentation for other devs including Future Seth but didn't want to expose it in the help file. If you want to make those methods public then by all means remove the tags.

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Feb 11, 2017

Weird.

I created the encoded file in an ad-hoc Docker container (so as to not spill all those Ruby gems needed to run the travis command-line tool). And I then created a new encoded file (with a throw-away GMail account for accessing a Google API) which is not yet deployed. Seems as if that had a side effect with this token.

Very strange. Well, repaired now. We'll see how fragile it is. If it is too much of a mess we can always turn the two env vars in .travis.yml back off again.

@eddelbuettel eddelbuettel deleted the feature/travis_with_token branch Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.