Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature/travis with token #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
========================================
Coverage ? 54.7%
========================================
Files ? 7
Lines ? 287
Branches ? 0
========================================
Hits ? 157
Misses ? 130
Partials ? 0Continue to review full report at Codecov.
|
|
Very nice! |
|
Hope we didn't jinx it. Promptly failed. May have been temporary. Running now. And I gamed the coverage stats like the best of them :) Shall we turn off the @nord tags you added? If documentation was written why not show it? |
|
Ha! WRT the @nord tag, those were only on the .isValid* functions which aren't currently exported. I wanted to leave documentation for other devs including Future Seth but didn't want to expose it in the help file. If you want to make those methods public then by all means remove the tags. |
|
Weird. I created the encoded file in an ad-hoc Docker container (so as to not spill all those Ruby gems needed to run the Very strange. Well, repaired now. We'll see how fragile it is. If it is too much of a mess we can always turn the two env vars in |
=:-)
We now have Travis tests