Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condition use of token in Travis #48

Merged
merged 1 commit into from Apr 13, 2017

Conversation

@eddelbuettel
Copy link
Owner

commented Apr 13, 2017

also fix one typo as pointed out by @MichaelChirico in #47

@restonslacker Give it a look-over. Some documentation is here and here in case you want to back things up

should now improve things so that PRs from forks (like #47) will not break over their lack of keys

condition use of token in Travis
also fix one typo as pointed out by @MichaelChirico in #47
@codecov-io

This comment has been minimized.

Copy link

commented Apr 13, 2017

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         285    285           
=====================================
  Hits          285    285
Impacted Files Coverage Δ
R/setup.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375415f...ef36cae. Read the comment docs.

@restonslacker

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2017

@eddelbuettel I won't have time for another week to really test this out, but reading over it, I don't think that this will cause me any problems.

@eddelbuettel eddelbuettel merged commit b66c07c into master Apr 13, 2017

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 375415f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the feature/travis_tests branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.