Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pbGetPost function and modify .createPush for this #54

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@mrchypark
Copy link
Contributor

commented Jul 18, 2019

add function to get post using pushbullet api https://docs.pushbullet.com/#list-pushes.

only add param limit first.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jul 18, 2019

Looks pretty straightforward and clean adding the new param at end to .createPush -- thanks!

@eddelbuettel eddelbuettel merged commit dbaa994 into eddelbuettel:master Jul 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jul 18, 2019

Can you think of a possible test? For now a few lines in simpleTests.R would do.

@mrchypark

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

Can you explain about simpleTests.R now? If it can check post count, will be great.

I set test post count == 0 first, and test again end of test and check post count > 0.
Is it right beginning of test, post count is 0?

or maybe all case of test post count > 0 would be fine.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jul 18, 2019

Yes count changing from zero to greater than zero after we do one of the pushes should do.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jul 19, 2019

Made a minimal change to "plural" in the function name as multiple posts may get returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.