Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let pbGetPosts use UTF-8 encoding #55

Merged
merged 2 commits into from Jul 21, 2019
Merged

Conversation

@mrchypark
Copy link
Contributor

@mrchypark mrchypark commented Jul 21, 2019

pbGetPosts is more suitable.

And fix encoding issue on windows non-english language.

I'm sorry don't understand your test code. how do I add test?

mrchypark added 2 commits Jul 21, 2019
@mrchypark mrchypark changed the title fix name and encoding pbGetPost to fix name pbGetPosts and encoding UTF-8 Jul 21, 2019
@eddelbuettel eddelbuettel changed the title pbGetPost to fix name pbGetPosts and encoding UTF-8 Let pbGetPosts use UTF-8 encoding Jul 21, 2019
@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jul 21, 2019

As you saw, I had already made the change adding the plural 's' to pbGetPosts

Adding encoding is useful. I'll merge that as a quick squash merge as your fork was out of sync anyway.

Tests can be simple. By default, during R CMD check every file ending in .R in the tests/ directory is executed. We already have tests/simpleTests.R so it was mostly a suggestion to add two or three lines to attempt to run pbGetPosts() (after having posted something) to see if we get something back, as one would expect. But I released by now anyway so no hurry.

@eddelbuettel eddelbuettel merged commit 52ab821 into eddelbuettel:master Jul 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.