Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate init.R to fix issue # 57 #59
Merged
Conversation
|
You write (and wrote in the previous) that you change from 2.0 to 1.1. But the code seems to set a '2'. Which part am I not reading correctly? |
|
It's a bit misleading, but 2 is an enum which corresponds to http v1.1 according to the the curl documentation (https://cran.r-project.org/web/packages/curl/vignettes/intro.html#disabling_http2) http v2.0 is enum = 3 I believe, which is used by default according to jeroen https://github.com/eddelbuettel/rpushbullet/issues/57#issuecomment-554952335 |
eddelbuettel
merged commit a309bae
into
eddelbuettel:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Changed .getCurlHandle() to make it use HTTP v1.1 instead of v2.0. This change has resolved my issue where pbPost() would randomly fail due to an an HTTP2 framing layer issue caused by curl::curl_fetch_memory(pburl, handle=h)