Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBuild on windows using rwinlib and BH #105
Conversation
| # Copyright 2005 Uwe Ligges | ||
| # Copyright 2008 - 2015 Dirk Eddelbuettel | ||
| # Copyright 2011 Uwe Ligges, Brian Ripley, and Josh Ulrich | ||
|
|
eddelbuettel
Apr 27, 2018
Owner
It's a little unusual to remove old attribution so I'll probably put this back in.
It's a little unusual to remove old attribution so I'll probably put this back in.
| @@ -13,10 +13,9 @@ Depends: R (>= 2.10.0) | |||
| Suggests: rgl, RUnit, shiny | |||
| LazyLoad: true | |||
| Imports: methods, Rcpp (>= 0.11.0), stats, graphics, zoo | |||
| LinkingTo: Rcpp | |||
| LinkingTo: BH, Rcpp | |||
eddelbuettel
Apr 27, 2018
Owner
I have to think this through. I am not sure yet if that is good. Maybe using the same Boost that QL was build with is better.
But this helps for win-builder. Maybe I just fold it in and out as needed.
I have to think this through. I am not sure yet if that is good. Maybe using the same Boost that QL was build with is better.
But this helps for win-builder. Maybe I just fold it in and out as needed.
|
The fail could be
or something else. |
|
Your branch fails for me too here, whereas my master passes. I suspect BH + Boost. |
|
And then it passes. So with that can you please make three changes to the PR:
All this gives me a way to build a binary and may keep RQL still off CRAN. |
|
Without BH we don't have the required boost headers. Also R will refuse to build anything on Windows that has |
|
With BH you bomb on Travis. Travis has had Boost -dev packages installed for years, else it would not work. So we a) do not need BH and b) it creates problems. What I am basically suggesting that the PR to Does that make sense? |
|
And you rock. I was just about to ask you to add the Boost headers to the quantlib library in rwinlib, and I see you are already on it. |
|
I doubt this will fix it but we'll see. Boost is 120MB of headers alone |
|
So on Debian/Ubuntu I do But this is now mergeable, no longer has a conditional DESCRIPTION -- so let me try and see if this will build on win-builder (without OS_type). |
|
Yes if we can somehow extract the subset of boost headers that quantlib needs that would relieve some of the weight. |
|
Glance at this script used by BH. Maybe if we just point at 'test'? |
|
Is it specified anywhere which |
|
'Base' (not sure what the name is) for boost::shared_ptr and all that, the boost test framework and maybe one more. For the Debian package I add the same two as I add for Travis: |
|
But |
|
It does have a lot, as there are interdependencies. But there are a dozen more
|
f3fd11c
into
eddelbuettel:master
Not saying that this is how you need to do it, but at least this will work on win builder so you can download the binary packages put them on your drat.