Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMore enums #54
Merged
More enums #54
Conversation
|
Looks like a clean patch. Does To merge it would be much preferable to have the test pass... |
|
Yes it does. I have disabled one test let's see what happens. |
thrasibule
force-pushed the
thrasibule:more_enums
branch
3 times, most recently
from
cd058f7
to
0ab842e
and others
added 4 commits
May 17, 2016
|
This looks good; merging now. |
eddelbuettel
merged commit 0190b52
into
eddelbuettel:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This closes #53 and closes #52.