Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSABR swaption #60
SABR swaption #60
Conversation
Merge pull request #48 from tleitch/master
Merge branch 'master' of https://github.com/eddelbuettel/rquantlib # Conflicts: # DESCRIPTION
fix merge issue
cleanup
changed maintainer to submit to winbuilder
|
Looks great at a first glance. I may go over it a bit and re-indent a little here or there. Congrats also on having become a git(hub) ninja :) |
|
Thanks. I'm sure I have room for much improvement, but I have a base process to catch (most) of the stupid stuff. I have someone who I've asked to develop a unit test for this and I'm waiting for a reply. I decided to commit now as it is a natural break for me and the unit test will be incremental. |
|
By the way, on the indentation in C++, RStudio doesn't know what to do with the ".with" and just keeps indenting. I took them out by hand, but it just put it back. |
|
Well RStudio is not the only editor. The real pros use external formatters and specification (and by the way Google also has one for R: rfmt) or common definitions for editors. I just use Emacs mode a little more informally ... |
14ba091
into
eddelbuettel:master
| @@ -0,0 +1 @@ | |||
| # cftc | |||
eddelbuettel
Jul 23, 2016
Owner
Did you mean to expand this?
Did you mean to expand this?
|
There are still a few warts that come up in testing:
I'll tackle those. I re-indented some, made some |
- some reindentation / whitespace fixes in R and C++ - suppress a few compiler warnings - fill in ChangeLog - update exports - correct shiny file modes to 00644
|
Some of these are close to this (now merged) PR. I open a new issue. |
SABR swaption module for European swaption valuation using a volcube was added. In addition, a data set was added, called rqlib, with a representative market for a volcube and a rate curve and a Shiny app that reads the data, calculates the payer and receiver for either the European or Bermudan, and displays the results.
It generates values using swaptionvolcube1 vol calac and then Black76 swaption model for Europeans, but for continuity, it will also value Bermudan swaption using markovfunctional and the provided volcube information.