Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tracking of arbitrary test parameters #2

Merged
merged 4 commits into from Nov 18, 2019

Conversation

@barbehenna
Copy link
Contributor

barbehenna commented Nov 18, 2019

I implemented a set of *_xl functions (one for each tinytest expect_* method) that append any extra parameters to the attributes of the test results. There's also a method, makeDataFrame, that can collect these arbitrary test attributes and return a data.frame.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #2 into master will decrease coverage by 51%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #2    +/-   ##
=====================================
- Coverage      85%   34%   -51%     
=====================================
  Files           2     4     +2     
  Lines          20    50    +30     
=====================================
  Hits           17    17            
- Misses          3    33    +30
Impacted Files Coverage Δ
R/expectations.R 100% <ø> (ø) ⬆️
R/expectations_xl.R 0% <0%> (ø)
R/methods.R 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7bebc4...42c2031. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Nov 18, 2019

Really nice work -- thank you!

@eddelbuettel eddelbuettel merged commit 6a18dee into eddelbuettel:master Nov 18, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 0% of diff hit (target 85%)
Details
codecov/project 34% (-51%) compared to b7bebc4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.