Fix TypeError when no joiOptions is provided, which will apply the joi defaults as well. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuc
added a commit
to verkstedt/feathers-hooks-validate-joi
that referenced
this pull request
Sep 17, 2019
Fix TypeError when no joiOptions is provided, which will apply the joi defaults as well. feathersjs-ecosystem#9
|
Surprise, @schettino! Thanks for the PR. Once the other one is merged, I'll release a new version. |
This was referenced Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently there is no way to use this lib passing an undefined joiOptions, applying joi defaults when it is undefined won't affect who is using this hook (backward compatible).
I have made the tests showing that convert will be true when using the joi defaults.