New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create W3C icon and make associated edits #166

Merged
merged 4 commits into from Jan 27, 2019

Conversation

Projects
None yet
2 participants
@judeGibbons
Copy link
Contributor

judeGibbons commented Jan 26, 2019

No description provided.

@edent

This comment has been minimized.

Copy link
Owner

edent commented Jan 26, 2019

Icon looks good. Two things before I can merge...

  1. There's a conflict with images/reference/index.md and radius.html - they don't include the changes you made in the Dribble PR.
  2. Can you make the icon smaller? Using something like https://jakearchibald.github.io/svgomg/ you can drop the precision, which should help.

Thanks :-)

@judeGibbons

This comment has been minimized.

Copy link
Contributor Author

judeGibbons commented Jan 27, 2019

OK, will do! I'm manually editing them but hadn't sussed out about the precision when I did those. Should I submit each new icon in a separate branch (which will always cause a conflict in the radius file)? And if I want to tweak a few at once should I also submit them separately or can they all go in one PR?

judeGibbons added some commits Jan 27, 2019

Merge pull request #1 from edent/master
Create Dribbble icon and make associated edits (#165)
@edent

This comment has been minimized.

Copy link
Owner

edent commented Jan 27, 2019

Best to do them separately, I think it might be time to get rid of the Radius file.

@edent edent merged commit 1067277 into edent:master Jan 27, 2019

@judeGibbons

This comment has been minimized.

Copy link
Contributor Author

judeGibbons commented Jan 27, 2019

Could logos be added to the radius file on separate lines? It could be reformatted every now and then to prevent it getting too long.

@judeGibbons judeGibbons deleted the judeGibbons:w3c-icon branch Jan 27, 2019

judeGibbons added a commit to judeGibbons/SuperTinyIcons that referenced this pull request Jan 27, 2019

Merge pull request #2 from edent/master
Create W3C icon and make associated edits (edent#166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment