Html pipeline #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,5 +19,5 @@ Gem::Specification.new do |gem| | |||
|
|
|||
| gem.add_dependency 'listen' | |||
| gem.add_dependency 'rb-fsevent' | |||
| gem.add_dependency 'httpclient' | |||
There was a problem hiding this comment.
httpclient is still required for fetching the stylesheet links.
|
This is awesome! Please verify the gemspec dependencies, and I will merge. |
|
Yep, I removed it in the first place since I was thinking about a way not to make an HTTP request at all. We could figure out a way to have the correct CSS in the gem maybe, but for the moment I think this is still an improvement since you make just one request for the CSS and don't use an API call to Github. |
|
I fetch the CSS links from github since the fingerprint on the URL will change over time. I do cache it for a day, but I'm thinking I'll change it to a week. Thanks for this! |
adamlogic
added a commit
that referenced
this pull request
Nov 29, 2012
Use Html pipeline locally instead of hitting the Github API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified it to use Github's html-pipeline instead of hitting the API. For some reason, I have to pass the :gfm => false parameter in order to ignore the breaklines from the markdown in the HTML.