Add a server option to specify the default authentication method #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current default authentication method is hardcoded to `SCRAM` and if
one wants a different default, something like this is currently
required:
CONFIGURE INSTANCE INSERT Auth {
priority := 0,
method := (INSERT Trust),
};
This is problematic because this configuration is persistent, so it's
harder to start an insecure server temporarily.
This patch adds the new `--default-auth-method` argument as well as its
companion `EDGEDB_SERVER_DEFAULT_AUTH_METHOD` environment variable to
set the default authentication method. `SCRAM` is still the default,
but devmode servers (`edb cli`) now set to `--default-auth-method=Trust`
as before.
tailhook
approved these changes
Sep 14, 2021
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default authentication method is hardcoded to
SCRAMand ifone wants a different default, something like this is currently
required:
This is problematic because this configuration is persistent, so it's
harder to start an insecure server temporarily.
This patch adds the new
--default-auth-methodargument as well as itscompanion
EDGEDB_SERVER_DEFAULT_AUTH_METHODenvironment variable toset the default authentication method.
SCRAMis still the default,but devmode servers (
edb cli) now set to--default-auth-method=Trustas before.