A train of fixes #1396
Merged
A train of fixes #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
May 14, 2020
| @@ -185,6 +185,7 @@ def _bool( | |||
| def _empty( | |||
| o: None, | |||
| repl_ctx: context.ReplContext, | |||
| render_ctx: RenderContext, | |||
There was a problem hiding this comment.
You're still using the Python repl?
1st1
reviewed
May 14, 2020
| @@ -646,10 +644,12 @@ def param_is_inherited( | |||
| p for p in new_params | |||
| if not param_is_inherited(new_schema, new, p) | |||
| ] | |||
| add = delta.add_prerequisite | |||
There was a problem hiding this comment.
nit: I'd call right here -- the code would be simpler (albeit a bit more repetitive).
1st1
approved these changes
May 14, 2020
When the result of link target intersection in `Foo.bar[IS Spam]` is empty, make sure that link property references with that prefix result in a reference error instead of a crash.
Type intersections (`[IS Type]`) have `AT_MOST_ONE` cardinality, so we
can forgo the refactoring fence enforcement on such paths if the
immediate prefix of the intersection is visible above in the scope tree.
This enables constructs like:
SELECT Issue {
references: {
[IS Publication].authors: {
name
} ORDER BY @list_order
}
}
and
SELECT Issue {
references[IS Publication]: {
title
} ORDER BY @list_order
}
If a link value is computaed by a `FOR` expression over a nested `INSERT` make sure that the iterator scope is visible so that link property expressions have the correct context.
Set-returning functions defined in terms of an SQL function with `OUT` params should not use coldeflists. This is already handled by the normal set-returning function handler, but not by the `enumerate()` specialization.
There appears to be no reason for `FUNCTION` to be a reserved keyword.
Parenthesized statements are not valid in all contexts in Postgres so take care not to parethesize the top level `SELECT` statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of assorted fixes that accumulated in my various branches.