Fix runner data buffer #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Alex-EEE , I'm ready to merge this, but I have one doubt - what if the actual data has 0x0 at the end of 1024 byte chunk? I guess we'd get No data or corrupt data received error again, but it's hard to say how common these situations will be. |
Collaborator
|
Aren't the packets all JSON exclusively? |
Contributor
Author
We concluded that this can be safely merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the amount of data received from .eim in certain cases does not fit in a single packet (1024 * 1024 bytes), it will not be parsed as valid json, and therefore the user will see
No data or corrupt data received error.