Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genshi doesn't support Python 3.8 #14

Closed
hodgestar opened this issue Oct 25, 2018 · 3 comments · Fixed by #16
Closed

Genshi doesn't support Python 3.8 #14

hodgestar opened this issue Oct 25, 2018 · 3 comments · Fixed by #16

Comments

@hodgestar
Copy link
Contributor

hodgestar commented Oct 25, 2018

It's the usual AST changes that break Genshi on every Python release.

From the original Genshi tracker bug report https://genshi.edgewall.org/ticket/612:

Python 3.8 now uses ast.Constant type and remove types like _ast.Str: ast.Str is a backward compatibility class.

I had to disable Genshi benchmark in the performance project: ​python/pyperformance#46

Example of issue: "strarg = _new(_ast.Str, node.id)" at genshi/template/eval.py:616: the code should use ast.Str, not _ast.Str.

See also https://bugs.python.org/issue32892.

Update: And the Python 3.8 release schedule -- https://www.python.org/dev/peps/pep-0569/ (release currently scheduled for 20 October 2019).

@FelixSchwarz
Copy link
Member

I assume nobody came up with a patch so far? (Fedora is preparing a Python 3.8 upgrade and unsurprisingly Genshi fails to build.)

downstream issue is Fedora bug 1693485: "python-genshi FTBFS with Python3.8"

@hroncok
Copy link
Contributor

hroncok commented Apr 24, 2019

I have a fix ready. Running tox to see if I broke something. I'm afraid I no longer have Python 2.5 around.

hroncok added a commit to hroncok/genshi that referenced this issue Apr 24, 2019
hroncok added a commit to hroncok/genshi that referenced this issue Apr 24, 2019
@hroncok
Copy link
Contributor

hroncok commented Apr 24, 2019

#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants