Updated Makefile for device-modbus-go #2
Conversation
| docker_device_modbus_go: | ||
| docker build \ | ||
| --label "git_sha=$(GIT_SHA)" \ |
There was a problem hiding this comment.
It doesn't look like GIT_SHA is being defined anywhere
There was a problem hiding this comment.
I was missing a build argument in .PHONY.
I pushed a minor change.
There was a problem hiding this comment.
The GIT_SHA should come as a global variable from the git commit hash.
There was a problem hiding this comment.
You'll still need to add a line like this one: https://github.com/edgexfoundry/device-random/blob/master/Makefile#L13
There was a problem hiding this comment.
thank you @mhall119 I have pushed that change now.
| docker_device_modbus_go: | ||
| docker build \ | ||
| --label "git_sha=$(GIT_SHA)" \ |
There was a problem hiding this comment.
You'll still need to add a line like this one: https://github.com/edgexfoundry/device-random/blob/master/Makefile#L13
There was a problem hiding this comment.
@jamesrgregg
Could you please squash your commit to only one?
jamesrgregg
force-pushed
the
modify-makefile-docker
branch
from
bb75798
to
0515eb5
Compare
Dockerfile
Outdated
| @@ -14,7 +14,12 @@ RUN echo http://nl.alpinelinux.org/alpine/v3.6/main > /etc/apk/repositories; \ | |||
| RUN apk update && apk add make && apk add bash | |||
| RUN apk add curl && apk add git && apk add openssh | |||
There was a problem hiding this comment.
We could remove your script from below and add glide to the apk add command here.
There was a problem hiding this comment.
Analogous to what happens here in config-seed Dockerfile https://github.com/edgexfoundry/edgex-go/blob/master/docker/Dockerfile.config-seed#L28-L34.
The issue you are currently hitting after you download the binary is that it's not on the PATH.
Installing via apk will solve this.
There was a problem hiding this comment.
@jamesrgregg disregard everything I just said above, my apologies. I just realized you said there was a compilation issue and I see it now.
There was a problem hiding this comment.
I also reverted back to the previous build image. The error is indicating that gcc isn't in the path.
I can perhaps try to add gcc via apk.
|
recheck |
- include docker build instructions in makefile for device-modbus-go Signed-off-by: James Gregg <james.r.gregg@intel.com> Updated Dockerfile for device-modbus-go - add base-build to include gcc to alpine Signed-off-by: James Gregg <james.r.gregg@intel.com>
jamesrgregg
force-pushed
the
modify-makefile-docker
branch
from
64428d1
to
3220272
Compare
…nt-interfaces feat(snap): add content interface for device configuration
Signed-off-by: James Gregg james.r.gregg@intel.com