Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit transformer on target process exit #395

Merged

Conversation

chazsconi
Copy link
Contributor

@chazsconi chazsconi commented Sep 30, 2019

When making an asynchronous response, if the target process dies (or is killed) there is no purpose in the transformer process still continuing to run, so we should kill this also.

This is a simple fix that I believe partially solves #375 . An alternative would be to allow the target process to kill the transformer in some way by sending it a message, but I think the approach in this PR is safer.

@edgurgel
Copy link
Owner

edgurgel commented Oct 1, 2019

I like this approach as it should not impact current users of the async requests 👍

Thank you for the PR!

@edgurgel edgurgel merged commit a597e64 into edgurgel:master Oct 1, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants