Add options to Search #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 27, 2016 14:30
edgurgel
reviewed
Feb 12, 2017
| @spec code(map, Client.t) :: Tentacat.response | ||
| def code(params, client \\ %Client{}) do | ||
| get "search/code", client, params | ||
| @spec code(map, Client.t, [atom]) :: Tentacat.response |
There was a problem hiding this comment.
I think in this case Keyword instead of [atom] seems more accurate. Sorry for the super late reply
|
This feature was done by https://github.com/edgurgel/tentacat/pull/100/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
Searchmodule does not allow you to pass options to the underlyingTentacat.getfunction. This means that it executes searches against the Github Api with the defaultpagination: :auto, which will quickly hit rate limits on the Search API for any fairly common search term (likelanguage:elixir). This PR allows options to be passed when invokingSearch's methods, letting the developer avoid this issue when needed.