Fix filepath never reaches root path #12
Conversation
|
Overall it looks good, but I can see a potential issue -- what if someone names a file with backslash on a Linux system? It may not happen in human named files, but can happen in some temporary files generated by some programs. |
| }; | ||
| function getFilepathRoot(filepath) { | ||
| var resolved = path.resolve(filepath); | ||
| var m = resolved.match(/[\\\/]/); |
There was a problem hiding this comment.
I was talking about this line. See my comments.
|
@xuhdev I don't think it matters, because my regex is searching for the first slash, which wouldn't have anything to do with the file name itself. Oh, but *nix paths start with a slash, so they are like |
|
BTW, we need to write tests for these use cases, @xuhdev. |
|
editorconfig/editorconfig-core-test@09e6038 Added the case with backslash in the glob on non windows system. |
|
You meant to add this case, right? |
|
Yeah. I guess the other scenario can't be accounted for as a test. Where EC is installed on a different drive letter. Not sure how a test would be written for that. |
jednano
force-pushed
the
fix-path-resolve
branch
from
fe98933
to
0314fdb
Compare
|
@xuhdev I've updated the commit to include your latest test. I also changed the |
|
I think everything's good now. For case with different drives, you can just run all tests different from your current drive. That is |
jednano
force-pushed
the
fix-path-resolve
branch
from
0314fdb
to
94f8ce7
Compare
Fix filepath never reaches root path
|
I just published patch release 0.12.1 for this |
Refer to #11