New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define minor-mode & Use prefix editorconfig- #43

Merged
merged 4 commits into from Nov 5, 2015

Conversation

Projects
None yet
3 participants
@10sr
Member

10sr commented Nov 1, 2015

This PR has two changes:

  1. Define minor-mode named editotconfig-mode

    Now EditorConfig properties will be applied only when this mode is enabled

  2. Use prefix editorconfifg- instead of edconf-

    Usually, when an Emacs package is loaded with (require 'package-a), then all symbols defined there will have a prefix package-a-. I think we should follow this convention.

    Old variables are marked obsolete.

@xuhdev

This comment has been minimized.

Member

xuhdev commented Nov 2, 2015

@10sr , many thanks for your effort! @johan @treyhunner What do you think of this change? I would support this change.

@treyhunner

This comment has been minimized.

Member

treyhunner commented Nov 2, 2015

I don't see a downside. I'll defer to someone more familiar with Emacs. @johan? 😸

xuhdev added a commit that referenced this pull request Nov 5, 2015

Merge pull request #43 from 10sr/minormode
Define minor-mode & Use prefix editorconfig- instead of edconf

@xuhdev xuhdev merged commit 5cc417b into editorconfig:master Nov 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xuhdev

This comment has been minimized.

Member

xuhdev commented Nov 5, 2015

Thanks, merged!

@xuhdev

This comment has been minimized.

Member

xuhdev commented Nov 5, 2015

@10sr Would you mind me adding you to the list of CONTRIBUTORS? Which name do you prefer to use in the list?

@10sr 10sr deleted the 10sr:minormode branch Nov 5, 2015

@10sr

This comment has been minimized.

Member

10sr commented Nov 5, 2015

Many many thanks!!!

@xuhdev

Would you mind me adding you to the list of CONTRIBUTORS?

Sounds great!

Which name do you prefer to use in the list?

Using 10sr is not preferable?
To be honest I don't really like to use my real name here, but of course I'll tell you if needed 😄

@xuhdev

This comment has been minimized.

Member

xuhdev commented Nov 5, 2015

@10sr it's fine, We can use 10sr. I'll add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment