Utilize autoload #73

Open
wants to merge 6 commits into
from

Projects

None yet

2 participants

@k-takata
k-takata commented Jan 7, 2017

Move most part from plugin/ to autoload/.
Also delay the initialization until it is really needed. (No need to initialize if no .editorconfig files are found.)
This reduces the startup time about 50 msec in my environment even if the files are cached by the OS.

k-takata added some commits Jan 7, 2017
@k-takata k-takata Check existence of .editorconfig before calling ec_core 4b3af31
@k-takata k-takata Remove redundant bufname checking
This is already checked in s:UseConfigFiles().
f0c8bf3
@k-takata k-takata Utilize autoload
Move most part from plugin/ to autoload/.
This reduces the startup time ~50 msec in my environment.
b70c94b
@k-takata k-takata Delay initialization until it is really needed 16d9f38
@xuhdev xuhdev self-requested a review Jan 7, 2017
@xuhdev

Overall it looks good. The dir editorconfig-core-py is actually a subtree from the repo https://github.com/editorconfig/editorconfig-core-py . Are you sure you don't need any specific handling about it?

@k-takata
k-takata commented Jan 8, 2017

Git subtree doesn't hold a local directory name unlike submodule.
So next time you pull editorconfig-core-py, you just need to specify the new directory with --prefix=.
E.g.

git subtree pull --prefix=autoload/editorconfig-core-py https://github.com/editorconfig/editorconfig-core-py.git master

(confirmed)

@k-takata
k-takata commented Jan 8, 2017

mkzip.sh has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment