Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No automatic final newline insertion anymore #74

Closed
TimonVS opened this issue Sep 26, 2016 · 3 comments
Closed

No automatic final newline insertion anymore #74

TimonVS opened this issue Sep 26, 2016 · 3 comments

Comments

@TimonVS
Copy link

TimonVS commented Sep 26, 2016

The plugin doesn't seem to insert a final newline anymore after the latest update.

This is my .editorconfig file:

# top-most EditorConfig file
root = true

# Unix-style newlines with a newline ending every file
[*]
end_of_line = lf
insert_final_newline = true

# Matches multiple files with brace expansion notation
# Set default charset
[*.{js,py}]
charset = utf-8

#4 space indentation
[*.py]
indent_style = space
indent_size = 4

# Tab indentation (no size specified)
[Makefile]
indent_style = tab

# Indentation override for all JS under lib directory
[lib/**.js]
indent_style = space
indent_size = 2

# Matches the exact files either package.json or .travis.yml
[{package.json,.travis.yml}]
indent_style = space
indent_size = 2
@SamVerschueren
Copy link
Collaborator

That's odd, it never seemed to fail on my system.

@jednano
Copy link
Member

jednano commented Sep 26, 2016

Please run the js core or another core on the file in question and verify that the setting is as you expect for that file first.

@TimonVS
Copy link
Author

TimonVS commented Sep 26, 2016

I must've been a little tired today. I called the file editorconfig instead of .editorconfig 😅. Thanks for your help!

@TimonVS TimonVS closed this as completed Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants