Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Magic Handle Lint/Format Issues #100

Open
edm00se opened this issue Feb 11, 2020 · 1 comment
Open

Auto-Magic Handle Lint/Format Issues #100

edm00se opened this issue Feb 11, 2020 · 1 comment
Assignees

Comments

@edm00se
Copy link
Owner

@edm00se edm00se commented Feb 11, 2020

TL;DR: Looking to implement samuelmeuli/lint-action or similar.

Situation

A contributor, not me, submits a high quality PR with their awesome board game. They used the web editor and missed a single character (some small amount of variance) causing the linter to complain and block the PR. This is 💩, since it's 99% awesome.

Why This Is Needed

My previous attempt (#62) worked well on master in this repo, but wasn't able to handle PRs as gracefully as desired. In short, it would require formatter/linting checking _after merging into master, causing additional commits. This is inefficient with the pattern of git and GH PRs, as we're meant to detect and address this stuff before merging.

@edm00se edm00se added the enhancement label Feb 11, 2020
@edm00se edm00se self-assigned this Feb 11, 2020
@edm00se

This comment has been minimized.

Copy link
Owner Author

@edm00se edm00se commented Feb 11, 2020

For the particular gh action mentioned above, it may need to wait for this to be resolved: samuelmeuli/lint-action#13

@edm00se edm00se added the blocked label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.