New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer build with latest poppler #5

Closed
jeroen opened this Issue Jan 8, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@jeroen
Copy link

jeroen commented Jan 8, 2019

The release notes of poppler 0.73 say:

* Remove Gulong, Guint, Gushort, Guchar typedefs.

When we try to build pdftoedn:

clang++ -DHAVE_CONFIG_H -I. -I..      -I/usr/local/Cellar/poppler/0.73.0/include -I/usr/local/Cellar/poppler/0.73.0/include/poppler -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/Cellar/libpng/1.6.36/include/libpng16 -I/usr/local/Cellar/leptonica/1.77.0_1/include/leptonica -I/usr/local/opt/openssl/include -Wno-user-defined-warnings -MT util_versions.o -MD -MP -MF $depbase.Tpo -c -o util_versions.o util_versions.cc &&\
	mv -f $depbase.Tpo $depbase.Po
util_encode.cc:146:27: error: unknown type name 'Guchar'
                          Guchar *pix = img_str->getLine();
                          ^
util_encode.cc:191:27: error: unknown type name 'Guchar'
                          Guchar pix[num_pix_comps];
                          ^
util_encode.cc:314:25: error: unknown type name 'Guchar'
                        Guchar pix;
                        ^
util_encode.cc:318:36: error: use of undeclared identifier 'Guchar'; did you mean 'char'?
                            pix = (Guchar) i;
                                   ^~~~~~
                                   char
util_encode.cc:460:21: error: unknown type name 'Guchar'
                    Guchar pix[num_pix_comps];
                    ^
util_encode.cc:461:21: error: unknown type name 'Guchar'
                    Guchar* mask_bits;
                    ^
util_encode.cc:642:25: error: unknown type name 'Guchar'
                        Guchar* pix = img_str->getLine();
                        ^
7 errors generated.
make[2]: *** [util_encode.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

I think the fix is simply to replace with unsigned char like here: freedesktop/poppler@51bb467

@SMillerDev SMillerDev referenced this issue Jan 8, 2019

Closed

poppler 0.73.0 #35785

5 of 5 tasks complete
@edporras

This comment has been minimized.

Copy link
Owner

edporras commented Jan 8, 2019

Yeah, poppler's been updating their internals on just about every release (I'm subscribed to their developer list). I won't be able to get to this until later today but will push a new release and updated formula as soon as I can. Thanks.

@jeroen

This comment has been minimized.

Copy link

jeroen commented Jan 8, 2019

Yes, only the poppler C++/glib/QT api's are stable. Anyway thanks for the quick response.

@edporras

This comment has been minimized.

Copy link
Owner

edporras commented Jan 8, 2019

Fixed in v0.36.4:
f4a9a39

@edporras edporras closed this Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment