New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRC] Several small changes #9

Merged
merged 8 commits into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@JJ
Contributor

JJ commented Jul 27, 2017

None critical, and in fact none to code except for adding requirements.

JJ added some commits Jul 27, 2017

Adds Pod::Usage to requirements
That was no big deal, actually. When accepted, closes #5
Added a README.md to support the Travis badge
At the same time closes #6 and closes #7.
@bricas

This comment has been minimized.

Show comment
Hide comment
@bricas

bricas Jul 28, 2017

Collaborator

Thanks for the PR!

This looks pretty good, except these two things:

  1. I don't think we want to "fix" #8 -- autogenerated files should not be in the repo
  2. The build badge links to your account and not this repo.

I would be happy to merge this once those two things are addressed.

Collaborator

bricas commented Jul 28, 2017

Thanks for the PR!

This looks pretty good, except these two things:

  1. I don't think we want to "fix" #8 -- autogenerated files should not be in the repo
  2. The build badge links to your account and not this repo.

I would be happy to merge this once those two things are addressed.

JJ added some commits Jul 28, 2017

Changed the badge to point to your repo
You'll still have to enable it in Travis. I see you already have an
account, so no big deal.

If it's OK to fix #8, I'll leave it here; if it's not, please tell me.
@bricas

This comment has been minimized.

Show comment
Hide comment
@bricas

bricas Jul 28, 2017

Collaborator

Sorry to nitpick, only 1 of the "JJ" items in the build status line was changed -- still one left.

Collaborator

bricas commented Jul 28, 2017

Sorry to nitpick, only 1 of the "JJ" items in the build status line was changed -- still one left.

@JJ

This comment has been minimized.

Show comment
Hide comment
@JJ

JJ Jul 28, 2017

Contributor

I actually changed the badge to point to @edsu's repos, but I can remove that too, no problem.

Contributor

JJ commented Jul 28, 2017

I actually changed the badge to point to @edsu's repos, but I can remove that too, no problem.

@bricas

This comment has been minimized.

Show comment
Hide comment
@bricas

bricas Jul 28, 2017

Collaborator

what? why are we removing the badge?

To clarify, before you removed it completely, you had:

[![Build Status](https://travis-ci.org/JJ/www-wikipedia.svg?branch=master)](https://travis-ci.org/edsu/www-wikipedia)

I would have expected it to be:

[![Build Status](https://travis-ci.org/edsu/www-wikipedia.svg?branch=master)](https://travis-ci.org/edsu/www-wikipedia)

Collaborator

bricas commented Jul 28, 2017

what? why are we removing the badge?

To clarify, before you removed it completely, you had:

[![Build Status](https://travis-ci.org/JJ/www-wikipedia.svg?branch=master)](https://travis-ci.org/edsu/www-wikipedia)

I would have expected it to be:

[![Build Status](https://travis-ci.org/edsu/www-wikipedia.svg?branch=master)](https://travis-ci.org/edsu/www-wikipedia)

@JJ

This comment has been minimized.

Show comment
Hide comment
@JJ

JJ Jul 28, 2017

Contributor

Ah, OK. Sorry.

Contributor

JJ commented Jul 28, 2017

Ah, OK. Sorry.

@bricas bricas merged commit 05f3a00 into edsu:master Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment