Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for GitHub Apps" #285

Closed

Conversation

BloggerBust-bot
Copy link

This reverts commit d800786.

Master is currently broken. By reverting back the GithubApp API version 3 changes from the dev branch unit tests will pass again and support for version 2 API will be restored.

@Jimeh87
Copy link

Jimeh87 commented Aug 30, 2019

I was able to get the app running on the latest from master by adding back v3 as an option for legacy auth. Not sure why it was suddenly removed for v3. See Jimeh87@392a83d for the change I made.

The only other issue I was running into was when I added a new comment, github was throwing a 404 error. Turns out the bot user needs the repo -> public_repo scope enabled as well as the admin:repo_hook read and write hooks. 🤷‍♂

@alexwaibel
Copy link
Collaborator

I decided to work to fix the current repo rather than rolling back these commits. This PR was useful to see at what point thing started breaking in the repo so thank you for this contribution even though I will not be merging in this PR.

@alexwaibel alexwaibel closed this Dec 13, 2019
caiopavanelli pushed a commit to caiopavanelli/staticman that referenced this pull request Aug 17, 2020
Instructions for Multilingual added on README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants