Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site level configuration for Akismet and Mailgun #372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pingu8007
Copy link

This PR aimed to cover issue #369 and #370. Following properties was added into siteConfig in this PR, which allowing site owner to override them on per site basis.

  • akismet.site: Site URL defined on Akismet. Should be an EncryptedString.
  • akismet.apiKey: ApiKey provided by Akismet. Should be an EncryptedString.
  • notifications.fromAddress: Custom sender address. Should be an EncryptedString. This property should match to the domain configured in same section. This property was documented as overridable but not implemented.

This PR also update the notification template to make overridden sender address take effect.

Staticman will read akismet configuration from siteConfig in first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant