Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename extension to smbclient, fix #21 #26

Merged
merged 4 commits into from Sep 11, 2015

Conversation

Projects
None yet
2 participants
@remicollet
Copy link
Contributor

commented Sep 9, 2015

Some notices about this PR

  • switch to "--enable-smbclient" but keep "--with-libsmbclient" for library location
  • add library check for smbc_getOptionUserData symbol (seems mandatory and not available in old version, e.g. samba 3.0 in RHEL-5)
  • rename constant to PHP_SMBCLIENT_VERSION (normalized for pecl)
  • use .gitignore to have a clean "git status" without any untracked file
  • still register "libsmbclient" ext to not break code (this probably could be dropped later)
@aklomp

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2015

Maybe we should first release 0.8.0, so that people who rely on the legacy library name still have a way to use the new features (streams, PHP7). We could keep the 0.8 branch as a place where we backport future work under the old library name.

@remicollet

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2015

as you want, but I would rather keep the 0.7.0 branch fr legacy.
0.8.0 is already a huge version... so IMHO a good time for the rename

@aklomp

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2015

It might be a good idea to remove Makefile.in from the project root, which still contains the old library name and is not otherwise used (I think, at least; deleting it has no effect).

So this pull request is only about changing the name of the .so extension file, right? Not about changing the name of the project itself? Because I think changing the project's name would be a careful undertaking, which might also involve renaming the repo. (Repo renames are "easy" in GitHub btw: all the old links keep working.)

I wonder if this pull request goes far enough. Maybe it would make sense to also rename internal things like php_libsmbclient_state_new and PHP_LIBSMBCLIENT_STATE_NAME to php_smbclient_state_new and PHP_SMBCLIENT_STATE_NAME. Shorter is better, and now would be the right time.

@remicollet

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2015

Not about changing the name of the project itself?

Yes, I don't see any reason to change the project / github name

@remicollet

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2015

Maybe it would make sense to also rename internal things...

My first idea was to do a "minimal" change. But yes it make sense, so : done in last commit.

aklomp added a commit that referenced this pull request Sep 11, 2015

Merge pull request #26 from remicollet/issue-21
Rename extension to smbclient, fix #21

@aklomp aklomp merged commit a2c2cd6 into eduardok:master Sep 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aklomp

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2015

Merged,. thanks!

@remicollet remicollet deleted the remicollet:issue-21 branch Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.