AUI-1208 Cloned fields displaying hidden attributes #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloned fields were only receiving the field properties of the original field during creation. Attributes like hiddenAttributes weren't being passed, so this configuration wouldn't be respected for cloned fields. While fixing this for hiddenAttribute I noticed that this was already happening for all other non-property attributes. I checked these other attributes one by one and this fix is now making sure that the ones that need to be passed over to the cloned field are doing so.
Sent from 
|
Just started reviewing :) |
|
Thank you, pull request merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.