New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Students suddenly cannot import repo into their assignments after many students completed their assignments successfully #1543

Closed
bvelez opened this Issue Sep 5, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@bvelez
Copy link

bvelez commented Sep 5, 2018

Please choose either issue or feature request

Issue

What you were trying to do ?

Offer a coding lab section using a GitHub Classroom assignment

What happened (include screenshot if you can) ?

After many students were able to create their assignment, Classroom begin giving this error:

githubclassroomerror

And did not allow any more students to create their assignments.

Step-by-step reproduction instructions

The link to my classroom is: https://classroom.github.com/classrooms/42574113-uprm-ciic4010-advanced-programming-fall-2018

Try to create assignment using this invitation link: https://classroom.github.com/a/CMps_6d3

Feature request

Please provide a description of the feature you would like Classroom to have

@bvelez

This comment has been minimized.

Copy link

bvelez commented Sep 5, 2018

I even tried to accept the assignment with my owner account and got the same error.

@BenEmdon

This comment has been minimized.

Copy link
Member

BenEmdon commented Sep 5, 2018

Hey @bvelez 👋 thanks for writing in.
It appears that your classroom accepted all the assignments quickly leading to your token getting rate limited.

If you get the students affected to accept their assignments an hour after an hour the problem may go away. Keep me updated if this problem persists. We are looking into a solution now.

@BenEmdon

This comment has been minimized.

Copy link
Member

BenEmdon commented Sep 6, 2018

We have identified a possible work around. @bvelez you will have to try the following steps:

This should regenerate your import token and allow your students to continue importing. You won't have to perform any import manually yourself.
Please let me know if this works.

@gkapfham

This comment has been minimized.

Copy link

gkapfham commented Sep 6, 2018

Hello @BenEmdon, thanks for posting this workaround. Someone from GitHub Education also sent me the same point by Twitter. Again, thanks. I start my laboratory session in a few minutes and thus I have to be brief. I have some questions which I will write out separately:

  • To clarify, is it enough for me to go to this mentioned site and login or do I actually need to do an import for each student in the class who is having a problem? (If needed, asking introductory students to do an import and to use the correct name is likely to be time consuming and error-prone).

  • How many imports at a single time will rate limit my account and cause the problem? Today, I am always running laboratory sessions of fewer than 40 students. Will that cause a problem?

  • Finally, any guess as to when you will merge the PR that seems to have a fix for this problem?

I'd like to know my options now so that if things don't work I don't set my classes too much further back to the point where we cannot cover the required amount of material during the laboratory sessions this semester. Thanks for any insights and for all of your work on GitHub Classroom. We've been using it in the past two years and would like to see all faculty in my department use it if we can iron out these issues.

@BenEmdon

This comment has been minimized.

Copy link
Member

BenEmdon commented Sep 6, 2018

Hey @gkapfham thanks for writing in on this thread.

To clarify, is it enough for me to go to this mentioned site and login or do I actually need to do an import for each student in the class who is having a problem? (If needed, asking introductory students to do an import and to use the correct name is likely to be time consuming and error-prone).

All you need to do is login on https://import.github.com/login. That will regenerate your source import token so that classroom can perform imports on your behalf. You won't need to perform an import for each student (that's Classrooms job 😄).

How many imports at a single time will rate limit my account and cause the problem? Today, I am always running laboratory sessions of fewer than 40 students. Will that cause a problem?

While I don't think that so few students will cause the problem, if the problem does occur, all you need to do:

Finally, any guess as to when you will merge the PR that seems to have a fix for this problem?

That PR (#1544) is an experiment that might reduce the likelihood of the problem, but the problem itself isn't caused by Classroom. The problem is occurring in a service hosted behind GitHub.com that is responsible for the source imports. They have been experiencing a high load from the back to school season and have seen some bottleneck issues. They are working very hard to scale up the import infrastructure. I am confident that our joint efforts will resolve this soon. No ETA on a stable solution yet. I will keep this thread posted.

Sorry for your inconvenience.

@BenEmdon

This comment has been minimized.

Copy link
Member

BenEmdon commented Sep 17, 2018

I'll go ahead and close this issue for now since it should be resolved. If you experience more problems creating assignments feel free to open a new issue!

@BenEmdon BenEmdon closed this Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment