Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-1372: Add switch to enable/disable data gathering from ec2 instances #5175

Conversation

@giovannicimolin
Copy link
Contributor

giovannicimolin commented Jun 6, 2019

This is needed in some deployments were S3 is being used for file
storage but the appserver is in another cloud provider, such as
OpenStack.

This issues started happening after the ec2_facts role was replaced with
the new version ec2_metadata_facts that fails when the server is not
on AWS, unlike its older counterpart.

This keeps the same behaviour as before, but allows disabling fact gathering.

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A DevOps team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a DEVOPS ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?
@edx-webhook

This comment has been minimized.

Copy link

edx-webhook commented Jun 6, 2019

Thanks for the pull request, @giovannicimolin! I've created OSPR-3627 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@giovannicimolin giovannicimolin changed the title BB-1372: Add switch to enable/disable data gathering from ec2 instances WIP BB-1372: Add switch to enable/disable data gathering from ec2 instances Jun 6, 2019
@giovannicimolin

This comment has been minimized.

Copy link
Contributor Author

giovannicimolin commented Jun 6, 2019

@natabene Can you try to prioritize this review?
It's blocking our sandboxes to be provisioned on the upstream PR's.
Thanks!

…s needed in some deployments were S3 is being used for file storage but the appserver is in another cloud provider, such as OpenStack.

This issues started happening after the ec2_facts role was replaced with 
the new version `ec2_metadata_facts` that fails when the server is not 
on AWS, unlike its older counterpart.
@giovannicimolin giovannicimolin force-pushed the open-craft:giovanni/bb-1372-optional-ec2-fact-gathering branch from 087428f to 4a44eaa Jun 6, 2019
Copy link
Contributor

Agrendalath left a comment

👍

  • I tested this: checked that the instance redeployment doesn't crash here on the OpenStack.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
@feanil

This comment has been minimized.

Copy link
Member

feanil commented Jun 6, 2019

@giovannicimolin Thank you for your contribution. Please let me know once tests are green and it is ready for our review.

@Agrendalath Agrendalath force-pushed the open-craft:giovanni/bb-1372-optional-ec2-fact-gathering branch from bb4b19d to 6d13d9f Jun 7, 2019
Agrendalath and others added 3 commits Jun 7, 2019
@giovannicimolin

This comment has been minimized.

Copy link
Contributor Author

giovannicimolin commented Jun 14, 2019

@feanil Ready for edX's review 😁

@edx-webhook

This comment has been minimized.

Copy link

edx-webhook commented Jun 14, 2019

Hello @giovannicimolin: We are unable to continue with review of your submission at this time. Please see the associated JIRA ticket for more explanation.

@edx-webhook

This comment has been minimized.

Copy link

edx-webhook commented Jun 14, 2019

@giovannicimolin Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@edx-webhook

This comment has been minimized.

Copy link

edx-webhook commented Jun 14, 2019

@giovannicimolin Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.