Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labxchange-xblocks to 0.3.0. #5483

Merged

Conversation

symbolist
Copy link
Contributor

Updates labxchange-xblocks dependency to 0.3.0. The changes in the new version are:


Make sure that the following steps are done before merging:

  • A DevOps team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a DEVOPS ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

@openedx-webhooks
Copy link

Thanks for the pull request, @symbolist! I've created OSPR-3911 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Oct 31, 2019
@symbolist
Copy link
Contributor Author

@ormsbee This is ready for your review. Thanks!

@natabene
Copy link
Contributor

natabene commented Nov 1, 2019

@symbolist Thank you for your contribution. @giovannicimolin Can you please prioritize this?

@ormsbee
Copy link

ormsbee commented Nov 1, 2019

@natabene: This is part of Blockstore/LabX work, separate from the normal OSPR flow.

@ormsbee ormsbee merged commit ffae11b into openedx:master Nov 1, 2019
@openedx-webhooks
Copy link

@symbolist 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@symbolist symbolist deleted the symbolist/upgrade-labxchange-xblocks branch November 4, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
4 participants