Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paypal payment processor default configuration #5501

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@regisb
Copy link
Contributor

regisb commented Nov 12, 2019

This is the companion PR of the upstream ecommerce repo:
edx/ecommerce#2684

The cancel_url configuration setting is not used by the paypal payment
processor in ecommerce. Instead, the payment processor uses the
cancel_checkout_path configuration parameter.

This error has been reported by two different users:
https://discuss.overhang.io/t/ecommerce-plugin-500-error-on-fresh-setup
https://openedx.slack.com/archives/C02SNA1U4/p1573488822105900?thread_ts=1573488555.104900&cid=C02SNA1U4

The proposed fix has worked in both cases.

Configuration Pull Request

Make sure that the following steps are done before merging:

  • [ ] A DevOps team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • [ ] Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • [ ] If you are updating a secure value rather than an internal one, file a DEVOPS ticket with details.
    • Add an entry to the CHANGELOG.
  • [ ] If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • [ ] Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release? Documentation is already up-to-date: https://edx-ecommerce.readthedocs.io/en/latest/additional_features/payment_processors.html
This is the companion PR of the upstream ecommerce repo:
edx/ecommerce#2684

The `cancel_url` configuration setting is not used by the paypal payment
processor in ecommerce. Instead, the payment processor uses the
`cancel_checkout_path` configuration parameter.

This error has been reported by two different users:
https://discuss.overhang.io/t/ecommerce-plugin-500-error-on-fresh-setup
https://openedx.slack.com/archives/C02SNA1U4/p1573488822105900?thread_ts=1573488555.104900&cid=C02SNA1U4

The proposed fix has worked in both cases.
@edx-webhook

This comment has been minimized.

Copy link

edx-webhook commented Nov 12, 2019

Thanks for the pull request, @regisb! I've created OSPR-3924 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@natabene

This comment has been minimized.

Copy link
Member

natabene commented Nov 13, 2019

@regisb Thank you for your contribution. @edx/devops Can you please give this a look ?

@natabene natabene requested review from edx/devops and fredsmith Nov 13, 2019
@fredsmith fredsmith merged commit a0e2306 into edx:master Nov 25, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@regisb regisb deleted the overhangio:regisb/fix-paypal-default-config branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.